On Tue, Feb 25, 2020 at 12:30:16PM +0000, Felipe Franciosi wrote: > > On Feb 25, 2020, at 12:19 PM, Felipe Franciosi <felipe@xxxxxxxxxxx> wrote: > >> /* for ioregionfd_cmd::info */ > >> #define IOREGIONFD_CMD_MASK 0xf > >> # define IOREGIONFD_CMD_READ 0 > >> # define IOREGIONFD_CMD_WRITE 1 > > > > Why do we need 4 bits for this? I appreciate you want to align the > > next field, but there's SIZE_SHIFT for that; you could have CMD_MASK > > set to 0x1 unless I'm missing something. The reserved space could be > > used for something else in the future. Yes, it's reserved for future commands. > >> The byte offset being accessed within that region is addr. > > > > It's not clear to me if addr is GPA absolute or an offset. Sounds like > > the latter, in which case isn't it preferable to name this "offset"? Yes, it's an offset into the region. "Offset" is clearer, thanks! Stefan
Attachment:
signature.asc
Description: PGP signature
