On 07/02/20 20:53, Sean Christopherson wrote: > >> 2) Return -EINVAL instead. > I agree that it _should_ be -EINVAL, but I just don't think it's worth > the possibility of breaking (stupid) userspace that was doing something > like: > > for (i = 0; i < max_cpuid_size; i++) { > cpuid.nent = i; > > r = ioctl(fd, KVM_GET_SUPPORTED_CPUID, &cpuid); > if (!r || r != -E2BIG) > break; > } > Apart from the stupidity of the above case, why would it be EINVAL? I can do the change to drop the initializer when applying. Paolo