Whild reading virtio code, I found some memory leak in removing virtio_net. In virtnet_remove, only skb has been freed not the pages in skb frags. Here is the patch to fix this, please review it. Signed-off-by: Shirley Ma <xma@xxxxxxxxxx> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 2a6e81d..7e629d9 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -978,6 +978,7 @@ static void virtnet_remove(struct virtio_device *vdev) /* Free our skbs in send and recv queues, if any. */ while ((skb = __skb_dequeue(&vi->recv)) != NULL) { + trim_pages(vi, skb); kfree_skb(skb); vi->num--; }
Signed-off-by: Shirley Ma <xma@xxxxxxxxxx> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 2a6e81d..7e629d9 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -978,6 +978,7 @@ static void virtnet_remove(struct virtio_device *vdev) /* Free our skbs in send and recv queues, if any. */ while ((skb = __skb_dequeue(&vi->recv)) != NULL) { + trim_pages(vi, skb); kfree_skb(skb); vi->num--; }