Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> writes: >linmiaohe <linmiaohe@xxxxxxxxxx> writes: > >> KVM_GET_CPUID2 ioctl is straight up broken > >It may make sense to add the gory details from your previous patch where you were trying to fix it. Will do. >> and not used anywhere. Remove it directly. >> >> Suggested-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> >> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx> >> #define KVM_GET_LAPIC _IOR(KVMIO, 0x8e, struct kvm_lapic_state) >> #define KVM_SET_LAPIC _IOW(KVMIO, 0x8f, struct kvm_lapic_state) >> #define KVM_SET_CPUID2 _IOW(KVMIO, 0x90, struct kvm_cpuid2) >> -#define KVM_GET_CPUID2 _IOWR(KVMIO, 0x91, struct kvm_cpuid2) > >Even if we decide to be strong and remove KVM_GET_CPUID2 completely, I'd suggest we leave a comment here saying that it was deprecated. Leaving the branch in case (returning the same -EINVAL as passing an unsupported >IOCTL) may also make sense (with a 'deprecated' comment of course). > Sounds reasonable. Will try. Many thanks!
