On 19/02/20 16:16, Sean Christopherson wrote: > The easy solution to that is to move retry_instruction() into emulate.c. > That would also allow making x86_page_table_writing_insn() static. All > other functions invoked from retry_instruction() are exposed via kvm_host.h. emulate.c is supposed to invoke no (or almost no) function outside the ctxt->ops struct. In particular, retry_instruction() invokes kvm_mmu_gva_to_gpa_write and kvm_mmu_unprotect_page. Paolo
