On Thu, Feb 20, 2020 at 3:23 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> On 18/02/20 20:07, Sean Christopherson wrote:
> > On Tue, Feb 18, 2020 at 10:47:56AM -0800, Oliver Upton wrote:
> >> Particularly draconian compilers warn of a possible uninitialized use of
> >> the nr_pages_avail variable. Silence this warning by initializing it to
> >> zero.
> > Can you check if the warning still exists with commit 6ad1e29fe0ab ("KVM:
> > Clean up __kvm_gfn_to_hva_cache_init() and its callers")? I'm guessing
> > (hoping?) the suppression is no longer necessary.
>
> What if __gfn_to_hva_many and gfn_to_hva_many are marked __always_inline?
>
> Thanks,
>
> Paolo
>
Even with this suggestion the compiler is ill-convinced :/
in re to Sean: what do I mean by "draconian compiler"
Well, the public answer is that both Barret and I use the same
compiler. Nothing particularly interesting about it, but idk what our
toolchain folks' stance is on divulging details.
I'll instead use Sean's suggested fix (which reads much better) and resend.
--
Thanks,
Oliver
