> -----邮件原件----- > 发件人: linmiaohe [mailto:linmiaohe@xxxxxxxxxx] > 发送时间: 2020年2月20日 16:18 > 收件人: Li,Rongqing <lirongqing@xxxxxxxxx>; pbonzini@xxxxxxxxxx; > vkuznets@xxxxxxxxxx > 抄送: Liran Alon <liran.alon@xxxxxxxxxx>; kvm@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx > 主题: Re: [PATCH][resend] KVM: fix error handling in svm_cpu_init > > Hi, > Li RongQing <lirongqing@xxxxxxxxx> writes: > > > >sd->save_area should be freed in error path > > > >Fixes: 70cd94e60c733 ("KVM: SVM: VMRUN should use associated ASID when > >SEV is enabled") > >Signed-off-by: Li RongQing <lirongqing@xxxxxxxxx> > >Reviewed-by: Brijesh Singh <brijesh.singh@xxxxxxx> > >Reviewed-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> > >--- > > arch/x86/kvm/svm.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > Oh, it's strange. This is already fixed in my previous patch : [PATCH v2] KVM: > SVM: Fix potential memory leak in svm_cpu_init(). > And Vitaly and Liran gave me Reviewed-by tags and Paolo queued it one month > ago. But I can't found it in master or queue branch. There might be something > wrong. :( In fact, I send this patch 2019/02/, and get Reviewed-by, but did not queue https://patchwork.kernel.org/patch/10853973/ and resend it 2019/07 https://patchwork.kernel.org/patch/11032081/ -Li