On Sun, Aug 09, 2009 at 06:14:32PM +0300, Avi Kivity wrote: > On 08/09/2009 06:07 PM, Gleb Natapov wrote: >>> It's still an "install handle, call handle" interface. Maybe it would >>> have been better to start off with your new interface, but having both >>> is too much for too little gain. >>> >>> >> Is it not too late to change interface? There was no released kernel with >> irqfd yet. And this just adds another level of indirection and one more >> point of false cache sharing. >> > > No irqfd, but we do have irq routing. The sharing isn't a problem since > it's read only. > We don't have many users of the old interface now. So what I propose is to retain old interface for use with old binaries, but limit the number of GSI entries to small number. New code should use new interface. Correct sharing is not the problem, but two levels of indirection still is (one indirection is to find list element another is to call function by pointer). -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
