On 14.02.20 19:39, David Hildenbrand wrote: > On 07.02.20 12:39, Christian Borntraeger wrote: >> From: Janosch Frank <frankja@xxxxxxxxxxxxx> >> >> This contains 3 main changes: >> 1. changes in SIE control block handling for secure guests >> 2. helper functions for create/destroy/unpack secure guests >> 3. KVM_S390_PV_COMMAND ioctl to allow userspace dealing with secure >> machines [...] > > I feel like my review comments for this patch were lost, so not > repeating them Basically you only asked if we could combine vm/vcpu_create/destroy into enable/disable. Janosch came up with some cases regarding error handling where the enable/disable would be hard to do right and exposing the single interfaces provide some advantages. If you still want to go down that path, please look at the next round of kernel/qemu patches and then lets discuss.
