On Fri, Feb 14, 2020 at 11:27:17AM +0100, Paolo Bonzini wrote:
> On 13/02/20 15:33, Andrew Jones wrote:
> > Users may need to temporarily provide additional VMM parameters.
> > The VMM_PARAMS environment variable provides a way to do that.
> > We take care to make sure when executing ./run_tests.sh that
> > the VMM_PARAMS parameters come last, allowing unittests.cfg
> > parameters to be overridden. However, when running a command
> > line like `$ARCH/run $TEST $PARAMS` we want $PARAMS to override
> > $VMM_PARAMS, so we ensure that too.
> >
> > Additional QEMU parameters can still be provided by appending
> > them to the $QEMU environment variable when it provides the
> > path to QEMU, but as those parameters will then be the first
> > in the command line they cannot override anything, and may
> > themselves be overridden.
>
> What about looking for "--" and passing to QEMU all parameters after it?
>
That was the way we originally planned on doing it when Alex Bennee posted
his patch. However since d4d34e648482 ("run_tests: fix command line
options handling") the "--" has become the divider between run_tests.sh
parameter inputs and individually specified tests. We'd have to change
that behavior, potentially breaking command lines, to go back to the
"--" approach.
Also, the nice thing about using an environment variable is that it works
with standalone tests too.
VMM_PARAMS="-foo bar" tests/mytest
will run the test with "-foo bar" appended to the command line. We could
modify mkstandalone.sh to get that feature too (allowing the additional
parameters to be given after tests/mytest), but with VMM_PARAMS we don't
have to.
Thanks,
drew
