On 13/02/20 15:32, Andrew Jones wrote: > + if [ -n "$QEMU" ]; then > + set -- $QEMU > + if ! "$1" --help 2>/dev/null | grep -q 'QEMU'; then > + echo "\$QEMU environment variable not set to a QEMU binary." >&2 > + return 2 > + fi > + qemu=$(command -v "$1") > + shift > + echo "$qemu $@" I think $* is more appropriate here. Something like "foo $@ bar" has a weird effect: $ set -x $ set a b c $ echo "foo $@ bar" + echo 'foo a' b 'c bar' foo a b c bar $ echo "foo $* bar" + echo 'foo a b c bar' foo a b c bar Otherwise, this is a good idea. Thanks, Paolo > + return > + fi > +
