On Tue, Feb 11, 2020 at 02:29:24PM -0800, Andy Lutomirski wrote: > On Tue, Feb 11, 2020 at 5:53 AM Joerg Roedel <joro@xxxxxxxxxx> wrote: > > + /* GDT loaded - switch to __KERNEL_CS so IRET works reliably */ > > + pushq $__KERNEL_CS > > + leaq .Lon_kernel_cs(%rip), %rax > > + pushq %rax > > + lretq > > + > > +.Lon_kernel_cs: > > + UNWIND_HINT_EMPTY > > I would suggest fixing at least SS as well. You are right, that is cleaner. Initialized DS, ES, and SS to __KERNEL_DS here too. Regards, Joerg