On 06/02/20 23:57, Krish Sadhukhan wrote:
>>
>> +
>> +void nested_svm_check_supported(void)
>> +{
>> + struct kvm_cpuid_entry2 *entry =
>> + kvm_get_supported_cpuid_entry(0x80000001);
>> +
>> + if (!(entry->ecx & CPUID_SVM)) {
>> + fprintf(stderr, "nested SVM not enabled, skipping test\n");
> I think a better message would be:
>
> "nested SVM not supported on this CPU, skipping test\n"
>
> Also, the function should ideally return a boolean and let the callers
> print whatever they want.
It would be "not supported by KVM", which is equivalent to "not enabled"
for all purposes.
Thanks,
Paolo
