Re: [RFC] eventfd: add EFD_AUTORESET flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 12/02/2020 10.31, Paolo Bonzini wrote:
On 29/01/20 18:20, Stefan Hajnoczi wrote:
+	/* Semaphore semantics don't make sense when autoreset is enabled */
+	if ((flags & EFD_SEMAPHORE) && (flags & EFD_AUTORESET))
+		return -EINVAL;
+
I think they do, you just want to subtract 1 instead of setting the
count to 0.  This way, writing 1 would be the post operation on the
semaphore, while poll() would be the wait operation.


poll() is usually idempotent. Both resetting to zero and subtracting one goes against the grain.


Better to use uring async read. This way you get the value just as you do with with poll+read, and the syscall cost is amortized away by uring.




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux