Hi Peter, On 2/11/20 5:24 PM, Peter Maydell wrote: > On Thu, 30 Jan 2020 at 11:26, Eric Auger <eric.auger@xxxxxxxxxx> wrote: >> >> Add 2 tests exercising chained counters. The first one uses >> CPU_CYCLES and the second one uses SW_INCR. >> >> Signed-off-by: Eric Auger <eric.auger@xxxxxxxxxx> >> +static void test_chained_sw_incr(void) >> +{ >> + uint32_t events[] = { 0x0 /* SW_INCR */, 0x0 /* SW_INCR */}; > > Cut-n-paste error? This test relies on the CHAIN event but it > isn't present in this list of events to pass to satisfy_prerequisites(), > so I suspect the second element should be "0x1e /* CHAIN */" ? No that's not a cut-n-paste error. I may rename the test into test_sw_incr. It starts by testing unchained SW_INCR. chained SW_INCR testing start with /* 64b SW_INCR */ > > (This makes the test fail on QEMU TCG, because we don't implement > CHAIN.) OK Thanks Eric > > thanks > -- PMM >