On 03/02/2020 14.19, Christian Borntraeger wrote:
> From: Janosch Frank <frankja@xxxxxxxxxxxxx>
>
> VCPU states have to be reported to the ultravisor for SIGP
> interpretation.
>
> Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
> ---
> arch/s390/kvm/kvm-s390.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 3ab5091ded6c..da8aeb24362a 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -4434,7 +4434,8 @@ void kvm_s390_vcpu_start(struct kvm_vcpu *vcpu)
> */
> __disable_ibs_on_all_vcpus(vcpu->kvm);
> }
> -
> + /* Let's tell the UV that we want to start again */
> + kvm_s390_pv_set_cpu_state(vcpu, PV_CPU_STATE_OPR);
> kvm_s390_clear_cpuflags(vcpu, CPUSTAT_STOPPED);
> /*
> * Another VCPU might have used IBS while we were offline.
> @@ -4462,6 +4463,8 @@ void kvm_s390_vcpu_stop(struct kvm_vcpu *vcpu)
> kvm_s390_clear_stop_irq(vcpu);
>
> kvm_s390_set_cpuflags(vcpu, CPUSTAT_STOPPED);
> + /* Let's tell the UV that we successfully stopped the vcpu */
> + kvm_s390_pv_set_cpu_state(vcpu, PV_CPU_STATE_STP);
> __disable_ibs_on_vcpu(vcpu);
>
> for (i = 0; i < online_vcpus; i++) {
As already mentioned, I'd move the kvm_s390_pv_set_cpu_state() from the
previous patch to this one here.
Anyway,
Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>
