Re: [RFCv2 18/37] KVM: s390: protvirt: Implement machine-check interruption injection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 05.02.20 14:47, Cornelia Huck wrote:
[..]
>> --- a/arch/s390/kvm/interrupt.c
>> +++ b/arch/s390/kvm/interrupt.c
>> @@ -571,6 +571,14 @@ static int __write_machine_check(struct kvm_vcpu *vcpu,
>>  	union mci mci;
>>  	int rc;
>>  
>> +	if (kvm_s390_pv_is_protected(vcpu->kvm)) {
>> +		vcpu->arch.sie_block->iictl = IICTL_CODE_MCHK;
>> +		vcpu->arch.sie_block->mcic = mchk->mcic;
>> +		vcpu->arch.sie_block->faddr = mchk->failing_storage_address;
>> +		vcpu->arch.sie_block->edc = mchk->ext_damage_code;
> 
> Maybe add a comment that we don't need with other machine-check related data?

Not sure I get this point. Can you make a proposal?

> 
>> +		return 0;
>> +	}
>> +
>>  	mci.val = mchk->mcic;
>>  	/* take care of lazy register loading */
>>  	save_fpu_regs();
> 
> Anyway,
> Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>
> 




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux