Re: [RFCv2 15/37] KVM: s390: protvirt: Implement interruption injection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 05.02.20 13:26, Michael Mueller wrote:
> 
> 
> On 05.02.20 13:11, Cornelia Huck wrote:
>> On Wed, 5 Feb 2020 12:46:39 +0100
>> Michael Mueller <mimu@xxxxxxxxxxxxx> wrote:
>>
>>> On 05.02.20 12:31, Cornelia Huck wrote:
>>>> On Mon,  3 Feb 2020 08:19:35 -0500
>>>> Christian Borntraeger <borntraeger@xxxxxxxxxx> wrote:
>>>>   
>>>>> From: Michael Mueller <mimu@xxxxxxxxxxxxx>
>>>>>
>>>>> The patch implements interruption injection for the following
>>>>> list of interruption types:
>>>>>
>>>>>     - I/O
>>>>>       __deliver_io (III)
>>>>>
>>>>>     - External
>>>>>       __deliver_cpu_timer (IEI)
>>>>>       __deliver_ckc (IEI)
>>>>>       __deliver_emergency_signal (IEI)
>>>>>       __deliver_external_call (IEI)
>>>>>
>>>>>     - cpu restart
>>>>>       __deliver_restart (IRI)
>>>>
>>>> Hm... what do 'III', 'IEI', and 'IRI' stand for?
>>>
>>> that's the kind of interruption injection being used:
>>>
>>> inject io interruption
>>> inject external interruption
>>> inject restart interruption
>>
>> So, maybe make this:
>>
>> - I/O (uses inject io interruption)
>>    __ deliver_io
>>
>> - External (uses inject external interruption)
>> (and so on)
>>
>> I find using the acronyms without explanation very confusing.
> 
> Make a guess from where they are coming...
> 
> Christian, would you please update the description accordingly.
> 
> 
>   - I/O (uses inject io interruption)
>     __deliver_io
> 
>   - External (uses inject external interruption)
>     __deliver_cpu_timer
>     __deliver_ckc
>     __deliver_emergency_signal
>     __deliver_external_call
> 
>   - cpu restart (uses inject restart interruption)
>     __deliver_restart

Will use that and also add.
Please note that posted interrupts (GISA) are not used for protected guests as of today.

> 
> thanks
> 
> Michael
> 
>>
>>>
>>>>   
>>>>>
>>>>> The service interrupt is handled in a followup patch.
>>>>>
>>>>> Signed-off-by: Michael Mueller <mimu@xxxxxxxxxxxxx>
>>>>> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
>>>>> [fixes]
>>>>> ---
>>>>>    arch/s390/include/asm/kvm_host.h |  8 +++
>>>>>    arch/s390/kvm/interrupt.c        | 93 ++++++++++++++++++++++----------
>>>>>    2 files changed, 74 insertions(+), 27 deletions(-)
>>
> 




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux