On 2/3/20 9:37 PM, Matthew Wilcox wrote: > On Fri, Jan 10, 2020 at 07:03:05PM +0000, Joao Martins wrote: >> @@ -4366,6 +4366,7 @@ EXPORT_SYMBOL(follow_pte_pmd); >> int follow_pfn(struct vm_area_struct *vma, unsigned long address, >> unsigned long *pfn) >> { >> + pmd_t *pmdpp = NULL; > > Please rename to 'pmdp'. > Will do. Alongside patch 4 usage of pmdpp and renaming 'pudpp' to 'pudp'.