On 04.02.20 12:18, Cornelia Huck wrote: > On Mon, 3 Feb 2020 08:19:26 -0500 > Christian Borntraeger <borntraeger@xxxxxxxxxx> wrote: > >> From: Vasily Gorbik <gor@xxxxxxxxxxxxx> >> >> Add exceptions handlers performing transparent transition of non-secure >> pages to secure (import) upon guest access and secure pages to >> non-secure (export) upon hypervisor access. >> >> Signed-off-by: Vasily Gorbik <gor@xxxxxxxxxxxxx> >> Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx> >> [adding checks for failures] >> Signed-off-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx> >> [further changes like adding a check for gmap fault] >> --- >> arch/s390/kernel/pgm_check.S | 4 +- >> arch/s390/mm/fault.c | 87 ++++++++++++++++++++++++++++++++++++ >> 2 files changed, 89 insertions(+), 2 deletions(-) >> >> diff --git a/arch/s390/kernel/pgm_check.S b/arch/s390/kernel/pgm_check.S >> index 59dee9d3bebf..27ac4f324c70 100644 >> --- a/arch/s390/kernel/pgm_check.S >> +++ b/arch/s390/kernel/pgm_check.S >> @@ -78,8 +78,8 @@ PGM_CHECK(do_dat_exception) /* 39 */ >> PGM_CHECK(do_dat_exception) /* 3a */ >> PGM_CHECK(do_dat_exception) /* 3b */ >> PGM_CHECK_DEFAULT /* 3c */ >> -PGM_CHECK_DEFAULT /* 3d */ >> -PGM_CHECK_DEFAULT /* 3e */ >> +PGM_CHECK(do_secure_storage_access) /* 3d */ >> +PGM_CHECK(do_non_secure_storage_access) /* 3e */ > > I suppose that these two can only happen when we actually run a > protected virt guest... yes to this and all other questions. [...] > IOW, we don't really introduce complex code paths for systems not > acting as protected virt hosts, even if we switch on the config option > or ditch it completely? Yes.