Hello Ryan,
see below...
Dne 29.7.2009 16:41, Ryan Harper napsal(a):
* Lucas Meneghel Rodrigues<lmr@xxxxxxxxxx> [2009-07-28 22:40]:
This patch adds a small setup script to set up huge memory
pages during the kvm tests execution. Also, added hugepage setup to the
fc8_quick sample.
Signed-off-by: Luká?? Doktor<ldoktor@xxxxxxxxxx>
Signed-off-by: Lucas Meneghel Rodrigues<lmr@xxxxxxxxxx>
Looks good. one nit below.
Signed-off-by: Ryan Harper<ryanh@xxxxxxxxxx>
---
+
+ def get_target_hugepages(self):
+ """
+ Calculate the target number of hugepages for testing purposes.
+ """
+ if self.vms< self.max_vms:
+ self.vms = self.max_vms
+ vmsm = (self.vms * self.mem) + (self.vms * 64)
Nit: Maybe a comment about the fudge factor being added in?
It's qemu-kvm overhead. Should I change the patch or is this explanation
sufficient?
Thanks for the feedback,
bye, Lukáš
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
