On Sun, 2 Feb 2020 20:44:35 +0800
gengdongjiu <gengdongjiu@xxxxxxxxxx> wrote:
> sorry for the late response due to Chinese new year
>
> On 2020/1/28 22:41, Igor Mammedov wrote:
> > On Wed, 8 Jan 2020 19:32:19 +0800
> > Dongjiu Geng <gengdongjiu@xxxxxxxxxx> wrote:
> >
> > in addition to comments of others:
> >
> >> Record the GHEB address via fw_cfg file, when recording
> >> a error to CPER, it will use this address to find out
> >> Generic Error Data Entries and write the error.
> >>
> >> Make the HEST GHES to a GED device.
[...]
> >> @@ -831,7 +832,9 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
> >> acpi_add_table(table_offsets, tables_blob);
> >> build_spcr(tables_blob, tables->linker, vms);
> >>
> >> - if (vms->ras) {
> >> + acpi_ged_state = ACPI_GED(object_resolve_path_type("", TYPE_ACPI_GED,
> >> + NULL));
> >> + if (acpi_ged_state && vms->ras) {
> >
> > there is vms->acpi_dev which is GED, so you don't need to look it up
> >
> > suggest:
> Thanks for the suggestion.
>
> > if (ras) {
> > assert(ged)
> assert(vms->acpi_dev), right?
yes, something like this.
> > do other fun stuff ...
> > }
>
> >
> >> acpi_add_table(table_offsets, tables_blob);
> >> build_ghes_error_table(tables->hardware_errors, tables->linker);
> >> acpi_build_hest(tables_blob, tables->hardware_errors,
[...]
