On 30/01/20 02:09, Eric Hankland wrote: > Sorry - I forgot to switch to plain text mode on my first reply. > >> I think this best written as it was before commit 2924b52117: >> >> if (!msr_info->host_initiated) >> data = (s64)(s32)data; >> pmc->counter += data - pmc_read_counter(pmc); > Sounds good to me. > >> Do you have a testcase? > I added a testcase to kvm-unit-tests/x86/pmu.c that fails without this > patch and passes with it. Should I send out that patch now? Yes, please send it! Thanks, Paolo
