Hi: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> wrote: > On Wed, Jan 22, 2020 at 11:21:44AM +0800, linmiaohe wrote: >> From: Miaohe Lin <linmiaohe@xxxxxxxxxx> >> >> It also helps eliminate some duplicated code. > > Reviewed-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> Thanks for your review. > >> if (ctxt->d & Fastop) { >> void (*fop)(struct fastop *) = (void *)ctxt->execute; > >The brackets can also be removed with a bit more cleanup, e.g. using a typedef to handling casting ctxt->execute. I'll send a patch that can be applied on top and/or squashed with this one. Thanks for doing this. :) > >> rc = fastop(ctxt, fop);