On 2020/1/17 15:22, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 1/16/20 5:46 PM, Peter Maydell wrote: >> On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng <gengdongjiu@xxxxxxxxxx> wrote: >>> >>> I and Xiang are willing to review the APEI-related patches and >>> volunteer as the reviewers for the HEST/GHES part. >>> >>> Signed-off-by: Dongjiu Geng <gengdongjiu@xxxxxxxxxx> >>> Signed-off-by: Xiang Zheng <zhengxiang9@xxxxxxxxxx> >>> --- >>> MAINTAINERS | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 387879a..5af70a5 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -1423,6 +1423,15 @@ F: tests/bios-tables-test.c >>> F: tests/acpi-utils.[hc] >>> F: tests/data/acpi/ >>> >>> +ACPI/HEST/GHES >>> +R: Dongjiu Geng <gengdongjiu@xxxxxxxxxx> >>> +R: Xiang Zheng <zhengxiang9@xxxxxxxxxx> >>> +L: qemu-arm@xxxxxxxxxx >>> +S: Maintained >>> +F: hw/acpi/ghes.c >>> +F: include/hw/acpi/ghes.h >>> +F: docs/specs/acpi_hest_ghes.rst >>> + >>> ppc4xx >>> M: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> >>> L: qemu-ppc@xxxxxxxxxx >>> -- >> >> Michael, Igor: since this new MAINTAINERS section is >> moving files out of the 'ACPI/SMBIOS' section that you're >> currently responsible for, do you want to provide an >> acked-by: that you think this division of files makes sense? > > The files are not 'moved out', Michael and Igor are still the maintainers of the supported ACPI/SMBIOS subsystem: > > ACPI/SMBIOS > M: Michael S. Tsirkin <mst@xxxxxxxxxx> > M: Igor Mammedov <imammedo@xxxxxxxxxx> > S: Supported > F: include/hw/acpi/* > F: hw/acpi/* > > Dongjiu and Xiang only add themselves as reviewers to get notified on changes on these specific files. The more eyes the better :) > > The docs/specs/acpi_hest_ghes.rst document has no maintainer, as these others too: If this file has no maintainer, may be it needs a M tag for this file, otherwise when people change this file, and use "./scripts/get_maintainer.pl xxxxx" to get maintainer, it will be empty. > > - docs/specs/acpi_cpu_hotplug.txt > - docs/specs/acpi_hw_reduced_hotplug.rst > - docs/specs/acpi_mem_hotplug.txt > - docs/specs/acpi_nvdimm.txt > > The only ACPI file reported as maintained in docs/specs/ is acpi_pci_hotplug.txt, from this entry: > > PCI > M: Michael S. Tsirkin <mst@xxxxxxxxxx> > M: Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx> > S: Supported > F: docs/specs/*pci* > > FWIW: > Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> > > . >