On Tue, 7 Jan 2020 20:01:42 +0800 Liu Yi L <yi.l.liu@xxxxxxxxx> wrote: > This patch has no code change, just a file copy. In following patches, > vfio_pci_common.c will be modified to only include the common functions > and related static functions in original vfio_pci.c. Meanwhile, vfio_pci.c > will be modified to only include vfio-pci module specific codes. > > Cc: Kevin Tian <kevin.tian@xxxxxxxxx> > Cc: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> > Signed-off-by: Liu Yi L <yi.l.liu@xxxxxxxxx> > --- > drivers/vfio/pci/vfio_pci_common.c | 1708 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 1708 insertions(+) > create mode 100644 drivers/vfio/pci/vfio_pci_common.c This whole procedure of "let's copy the file and rip out unneeded stuff later" looks very ugly to me, especially if I'd come across it in the future, e.g. during a bisect. This patch only adds a file that is not compiled, and later changes will be "rip out unwanted stuff from vfio_pci_common.c" instead of the more positive "move common stuff to vfio_pci_common.c". I think refactoring/moving interfaces/code that it makes sense to share makes this more reviewable, both now and in the future.
