On Fri, Jan 10, 2020 at 03:54:01PM +0100, Eric Auger wrote: ... > diff --git a/lib/arm/gic.c b/lib/arm/gic.c > index 8416dde..f9a6f57 100644 > --- a/lib/arm/gic.c > +++ b/lib/arm/gic.c > @@ -6,6 +6,7 @@ > #include <devicetree.h> > #include <asm/gic.h> > #include <asm/io.h> > +#include <asm/gic-v3-its.h> > > struct gicv2_data gicv2_data; > struct gicv3_data gicv3_data; > @@ -44,12 +45,14 @@ static const struct gic_common_ops gicv3_common_ops = { > * Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt > */ > static bool > -gic_get_dt_bases(const char *compatible, void **base1, void **base2) > +gic_get_dt_bases(const char *compatible, void **base1, void **base2, > + void **base3) Here's another place that I would prefer using our 120 chars. No need to put base3 on a new line. Thanks, drew