Done. I'll have it in the next version of the patch set I send out.
On Tue, Jan 7, 2020 at 8:00 AM Peter Xu <peterx@xxxxxxxxxx> wrote:
>
> On Mon, Dec 16, 2019 at 01:38:55PM -0800, Ben Gardon wrote:
>
> [...]
>
> > +static void *uffd_handler_thread_fn(void *arg)
> > +{
> > + struct uffd_handler_args *uffd_args = (struct uffd_handler_args *)arg;
> > + int uffd = uffd_args->uffd;
> > + int64_t pages = 0;
> > +
> > + while (!quit_uffd_thread) {
> > + struct uffd_msg msg;
> > + struct pollfd pollfd[1];
> > + int r;
> > + uint64_t addr;
> > +
> > + pollfd[0].fd = uffd;
> > + pollfd[0].events = POLLIN;
> > +
> > + /*
> > + * TODO this introduces a 0.5sec delay at the end of the test.
> > + * Reduce the timeout or eliminate it following the example in
> > + * tools/testing/selftests/vm/userfaultfd.c
> > + */
> > + r = poll(pollfd, 1, 500);
>
> Would you mind implement it instead of adding a todo? IIUC it's as
> simple as a few more lines than the comment itself. Thanks,
>
> --
> Peter Xu
>
