On Fri, Dec 13, 2019 at 5:10 PM Liran Alon <liran.alon@xxxxxxxxxx> wrote: > > > > > On 14 Dec 2019, at 2:20, Jim Mattson <jmattson@xxxxxxxxxx> wrote: > > > > More often than not, a failed VM-entry in a production environment is > > the result of a defective CPU (at least, insofar as Intel x86 is > > concerned). To aid in identifying the bad hardware, add the logical > > CPU to the information provided to userspace on a KVM exit with reason > > KVM_EXIT_FAIL_ENTRY. The presence of this additional information is > > indicated by a new capability, KVM_CAP_FAILED_ENTRY_CPU. > > > > Signed-off-by: Jim Mattson <jmattson@xxxxxxxxxx> > > Reviewed-by: Oliver Upton <oupton@xxxxxxxxxx> > > Cc: Liran Alon <liran.alon@xxxxxxxxxx> > > Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx> > > Reviewed-by: Liran Alon <liran.alon@xxxxxxxxxx> > > BTW, one could argue that receiving an unexpected exit-reason (i.e. KVM_INTERNAL_ERROR_UNEXPECTED_EXIT_REASON) > could also only occur in production either from a KVM bug or from a defective CPU. Similar to failed VM-entry. > Should we add similar behaviour to that as-well? > > -Liran That's a good point. We had one case of numerous VM-exits for INIT, and I'm pretty sure that was a defective CPU too.
