> On Dec 13, 2019, at 12:59 AM, Jim Mattson <jmattson@xxxxxxxxxx> wrote: > > On Sat, May 18, 2019 at 4:58 PM Nadav Amit <nadav.amit@xxxxxxxxx> wrote: >> The test that checks the maximum VMCS field encoding does not probe all >> possible VMCS fields. As a result it might fail since the actual >> IA32_VMX_VMCS_ENUM.MAX_INDEX would be higher than the expected value. >> >> Change the test to check that the maximum of the supported probed >> VMCS fields is lower/equal than the actual reported >> IA32_VMX_VMCS_ENUM.MAX_INDEX. > > Wouldn't it be better to probe all possible VMCS fields and keep the > test for equality? It might take a while though… How about probing VMREAD/VMWRITE to MAX_INDEX in addition to all the known VMCS fields and then checking for equation?