On 12.12.19 16:12, Christian Borntraeger wrote:
>
>
> On 12.12.19 15:08, Pandurov, Milan wrote:
>>
>> On 12.12.19 10:34, Alexander Graf wrote:
>
>>>> @@ -4013,8 +4013,9 @@ static int kvm_debugfs_open(struct inode *inode, struct file *file,
>>>> return -ENOENT;
>>>> if (simple_attr_open(inode, file, get,
>>>> - stat_data->mode & S_IWUGO ? set : NULL,
>>>> - fmt)) {
>>>> + KVM_DBGFS_GET_MODE(stat_data->dbgfs_item) & 0222
>>>
>>> Why do you change the mask from S_IWUGO to 0222?
>> checkpatch was complaining: "Symbolic permissions 'S_IWUGO' are not preferred. Consider using octal permissions '0222'."
>> I will change it back to S_IWUGO in next revision to avoid confusion.
>
>
> I think most people prefer the octal ones. Linus was very vocal about the S_xxxxx being
> incomprehensible, so please keep it octal.
https://lwn.net/Articles/696229/
