Hi Milan, Thank you for the patch! Yet something to improve: [auto build test ERROR on kvm/linux-next] [also build test ERROR on vhost/linux-next v5.5-rc1 next-20191210] [cannot apply to kvms390/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Milan-Pandurov/kvm-Refactor-handling-of-VM-debugfs-files/20191211-063504 base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next config: mips-malta_kvm_defconfig (attached as .config) compiler: mipsel-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): arch/mips/kvm/../../../virt/kvm/kvm_main.c: In function 'vm_stat_get': >> arch/mips/kvm/../../../virt/kvm/kvm_main.c:4126:3: error: implicit declaration of function 'vm_stat_get_per_vm'; did you mean 'vm_stat_get'? [-Werror=implicit-function-declaration] vm_stat_get_per_vm(kvm, offset, &tmp_val); ^~~~~~~~~~~~~~~~~~ vm_stat_get arch/mips/kvm/../../../virt/kvm/kvm_main.c: In function 'vm_stat_clear': >> arch/mips/kvm/../../../virt/kvm/kvm_main.c:4143:3: error: implicit declaration of function 'vm_stat_clear_per_vm'; did you mean 'vm_stat_clear'? [-Werror=implicit-function-declaration] vm_stat_clear_per_vm(kvm, offset); ^~~~~~~~~~~~~~~~~~~~ vm_stat_clear arch/mips/kvm/../../../virt/kvm/kvm_main.c: In function 'vcpu_stat_get': >> arch/mips/kvm/../../../virt/kvm/kvm_main.c:4161:3: error: implicit declaration of function 'vcpu_stat_get_per_vm'; did you mean 'vcpu_stat_get'? [-Werror=implicit-function-declaration] vcpu_stat_get_per_vm(kvm, offset, &tmp_val); ^~~~~~~~~~~~~~~~~~~~ vcpu_stat_get cc1: all warnings being treated as errors vim +4126 arch/mips/kvm/../../../virt/kvm/kvm_main.c 4116 4117 static int vm_stat_get(void *_offset, u64 *val) 4118 { 4119 unsigned offset = (long)_offset; 4120 struct kvm *kvm; 4121 u64 tmp_val; 4122 4123 *val = 0; 4124 mutex_lock(&kvm_lock); 4125 list_for_each_entry(kvm, &vm_list, vm_list) { > 4126 vm_stat_get_per_vm(kvm, offset, &tmp_val); 4127 *val += tmp_val; 4128 } 4129 mutex_unlock(&kvm_lock); 4130 return 0; 4131 } 4132 4133 static int vm_stat_clear(void *_offset, u64 val) 4134 { 4135 unsigned offset = (long)_offset; 4136 struct kvm *kvm; 4137 4138 if (val) 4139 return -EINVAL; 4140 4141 mutex_lock(&kvm_lock); 4142 list_for_each_entry(kvm, &vm_list, vm_list) { > 4143 vm_stat_clear_per_vm(kvm, offset); 4144 } 4145 mutex_unlock(&kvm_lock); 4146 4147 return 0; 4148 } 4149 4150 DEFINE_SIMPLE_ATTRIBUTE(vm_stat_fops, vm_stat_get, vm_stat_clear, "%llu\n"); 4151 4152 static int vcpu_stat_get(void *_offset, u64 *val) 4153 { 4154 unsigned offset = (long)_offset; 4155 struct kvm *kvm; 4156 u64 tmp_val; 4157 4158 *val = 0; 4159 mutex_lock(&kvm_lock); 4160 list_for_each_entry(kvm, &vm_list, vm_list) { > 4161 vcpu_stat_get_per_vm(kvm, offset, &tmp_val); 4162 *val += tmp_val; 4163 } 4164 mutex_unlock(&kvm_lock); 4165 return 0; 4166 } 4167 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation
Attachment:
.config.gz
Description: application/gzip