Avi Kivity wrote:
> On 07/28/2009 10:16 AM, Jan Kiszka wrote:
>> Hi,
>>
>> why do we wait on condition variables with silly timeouts (both in
>> upstream as in qemu-kvm)? There used to be some qemu_aio_poll in
>> qemu-kvm, but it's no longer there, and upstream never had (unless I
>> missed something). Is this polling legacy now? Remove it?
>>
>>
>
> Given that all uses are inside while loops, the timeouts are ignored.
> It's completely pointless now.
>
Then let's start with removing it from qemu-kvm:
------------>
No caller of qemu_cond_wait makes use of this polling anymore. Remove
it.
Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
---
qemu-kvm.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/qemu-kvm.c b/qemu-kvm.c
index 32dce4a..0615d06 100644
--- a/qemu-kvm.c
+++ b/qemu-kvm.c
@@ -1557,12 +1557,8 @@ static inline unsigned long kvm_get_thread_id(void)
static void qemu_cond_wait(pthread_cond_t *cond)
{
CPUState *env = cpu_single_env;
- static const struct timespec ts = {
- .tv_sec = 0,
- .tv_nsec = 100000,
- };
- pthread_cond_timedwait(cond, &qemu_mutex, &ts);
+ pthread_cond_wait(cond, &qemu_mutex);
cpu_single_env = env;
}
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
