Re: [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/12/2019 13.51, Christian Borntraeger wrote:
> There is no ENOTSUPP for userspace
> 
> Reported-by: Julian Wiedmann <jwi@xxxxxxxxxxxxx>
> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> ---
>  arch/s390/kvm/interrupt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 2a711bae69a7..bd9b339bbb5e 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -2312,7 +2312,7 @@ static int flic_ais_mode_get_all(struct kvm *kvm, struct kvm_device_attr *attr)
>  		return -EINVAL;
>  
>  	if (!test_kvm_facility(kvm, 72))
> -		return -ENOTSUPP;
> +		return -EOPNOTSUPP;
>  
>  	mutex_lock(&fi->ais_lock);
>  	ais.simm = fi->simm;
> @@ -2621,7 +2621,7 @@ static int modify_ais_mode(struct kvm *kvm, struct kvm_device_attr *attr)
>  	int ret = 0;
>  
>  	if (!test_kvm_facility(kvm, 72))
> -		return -ENOTSUPP;
> +		return -EOPNOTSUPP;
>  
>  	if (copy_from_user(&req, (void __user *)attr->addr, sizeof(req)))
>  		return -EFAULT;
> @@ -2701,7 +2701,7 @@ static int flic_ais_mode_set_all(struct kvm *kvm, struct kvm_device_attr *attr)
>  	struct kvm_s390_ais_all ais;
>  
>  	if (!test_kvm_facility(kvm, 72))
> -		return -ENOTSUPP;
> +		return -EOPNOTSUPP;
>  
>  	if (copy_from_user(&ais, (void __user *)attr->addr, sizeof(ais)))
>  		return -EFAULT;
> 

Good catch.

Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>

There seems to be another one in arch/s390/include/asm/uv.h, are you
going to fix that, too?




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux