> Am 28.11.2019 um 20:16 schrieb Pierre Morel <pmorel@xxxxxxxxxxxxx>: > > >> On 2019-11-28 15:36, David Hildenbrand wrote: >>> On 28.11.19 13:46, Pierre Morel wrote: >>> Let's define the PSW bits explicitly, it will clarify their >>> usage. >>> >>> Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx> >>> --- >>> lib/s390x/asm/arch_bits.h | 20 ++++++++++++++++++++ >>> lib/s390x/asm/arch_def.h | 6 ++---- >> I'm sorry, but I don't really see a reason to move these 4/5 defines to >> a separate header. Can you just keep them in arch_def.h and extend? > > no because arch_def.h contains C structures and inline. (resend because the iOS Mail app does crazy html thingies) You‘re looking for #ifndef __ASSEMBLER__ ... See lib/s390x/asm/sigp.h