On 2019/11/25 17:48, Igor Mammedov wrote: >>> ...... >>> bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE, >>> ACPI_GHES_ERROR_STATUS_ADDRESS_OFFSET(hest_start, source_id), >>> sizeof(uint64_t), ACPI_GHES_ERRORS_FW_CFG_FILE, >>> source_id * sizeof(uint64_t)); >>> ....... >>> } >>> >>> My previous series patch support 2 error sources, but now only enable 'SEA' type Error Source >> I'd try to merge this, worry about extending things later. >> This is at v21 and the simpler you can keep things, >> the faster it'll go in. > I don't think the series is ready for merging yet. > It has a number of issues (not stylistic ones) that need to be fixed first. > > As for extending, I think I've suggested to simplify series > to account for single error source only in some places so it > would be easier on author and reviewers and worry about extending > it later. sure, thanks for the review, we are preparing another series which will fix the issues that you mentioned. >
