[bug report] KVM: SVM: Reduce WBINVD/DF_FLUSH invocations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Tom Lendacky,

The patch 33af3a7ef9e6: "KVM: SVM: Reduce WBINVD/DF_FLUSH
invocations" from Oct 3, 2019, leads to the following static checker
warning:

	arch/x86/kvm/svm.c:6311 sev_flush_asids()
	error: uninitialized symbol 'error'.

arch/x86/kvm/svm.c
  6295  static int sev_flush_asids(void)
  6296  {
  6297          int ret, error;
  6298  
  6299          /*
  6300           * DEACTIVATE will clear the WBINVD indicator causing DF_FLUSH to fail,
  6301           * so it must be guarded.
  6302           */
  6303          down_write(&sev_deactivate_lock);
  6304  
  6305          wbinvd_on_all_cpus();
  6306          ret = sev_guest_df_flush(&error);
                                         ^^^^^^
  6307  
  6308          up_write(&sev_deactivate_lock);
  6309  
  6310          if (ret)
  6311                  pr_err("SEV: DF_FLUSH failed, ret=%d, error=%#x\n", ret, error);
                                                                                 ^^^^^
There are a bunch of error paths were "error" isn't initialized.

  6312  
  6313          return ret;
  6314  }

regards,
dan carpenter



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux