Re: [PATCH kvm-unit-tests] runtime: set MAX_SMP to number of online cpus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 11/20/19 2:19 PM, Andrew Jones wrote:
> We can only use online cpus, so make sure we check specifically for
> those.
>
> Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx>
> ---
>  scripts/runtime.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
> index 200d5b67290c..fbad0bd05fc5 100644
> --- a/scripts/runtime.bash
> +++ b/scripts/runtime.bash
> @@ -1,5 +1,5 @@
>  : "${RUNTIME_arch_run?}"
> -: ${MAX_SMP:=$(getconf _NPROCESSORS_CONF)}
> +: ${MAX_SMP:=$(getconf _NPROCESSORS_ONLN)}

I tested it on my machine by offlining a CPU and calling getconf _NPROCESSORS_CONF
(returned 32) and getconf _NPROCESSORS_ONLN (returned 31). man 3 sysconf also
agrees with your patch.

I am wondering though, if _NPROCESSORS_CONF is 8 and _NPROCESSORS_ONLN is 1
(meaning that 7 CPUs were offlined), that means that qemu will create 8 VCPUs
which will share the same physical CPU. Is that undesirable?

Thanks,
Alex
>  : ${TIMEOUT:=90s}
>  
>  PASS() { echo -ne "\e[32mPASS\e[0m"; }



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux