On 19/11/19 13:26, Vitaly Kuznetsov wrote: > What about ' << 4', don't we still need it? :-) And better APIC_ICR > instead of 0x300... > > Personally, I'd write something like > > if (index > APIC_BASE_MSR && (index - APIC_BASE_MSR) == APIC_ICR >> 4) > > and let compiler optimize this, I bet it's going to be equally good. Or "index == APIC_BASE_MSR + (APIC_ICR >> 4)". Paolo