On 2019/11/18 21:21, Michael S. Tsirkin wrote:
>> If use offset relative to GAS structure, the code does not easily extend to support more Generic Hardware Error Source.
>> if use offset relative to hest_start, just use a loop, the code can support more error source, for example:
>> for (source_id = 0; i<n; source_id++)
>> {
>> ......
>> bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE,
>> ACPI_GHES_ERROR_STATUS_ADDRESS_OFFSET(hest_start, source_id),
>> sizeof(uint64_t), ACPI_GHES_ERRORS_FW_CFG_FILE,
>> source_id * sizeof(uint64_t));
>> .......
>> }
>>
>> My previous series patch support 2 error sources, but now only enable 'SEA' type Error Source
> I'd try to merge this, worry about extending things later.
> This is at v21 and the simpler you can keep things,
> the faster it'll go in.
Thanks a lot for the comments. Yes, I think we can merge the v21 series.
