Re: [kvm-unit-tests PATCH 1/2] Makefile: use "-Werror" in cc-option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/11/19 18:47, Thomas Huth wrote:
> On 07/11/2019 02.08, Bill Wendling wrote:
>> The "cc-option" macro should use "-Werror" to determine if a flag is
>> supported. Otherwise the test may not return a nonzero result. Also
>> conditionalize some of the warning flags which aren't supported by
>> clang.
>>
>> Signed-off-by: Bill Wendling <morbo@xxxxxxxxxx>
>> ---
>>  Makefile | 20 ++++++++++++++------
>>  1 file changed, 14 insertions(+), 6 deletions(-)
> 
> Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>
> 

Queued, thanks.

(As for C++, the right thing to do would be to rewrite the tests for
tools/testing/selftests/kvm/ and get rid of it...).

Paolo





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux