Re: [PATCH] fix serious regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/22/2009 02:57 AM, Glauber Costa wrote:
Today I found a very catastrophic regression: I cannot run my mission
critical servers running RHL7.1 anymore. This is a total disaster.

Fortunately, I was able to isolate the commit that caused it:
     commit bb598da496c040d42dde564bd8ace181be52293e
     Author: Glauber Costa<glommer@xxxxxxxxxx>
     Date:   Mon Jul 6 16:12:52 2009 -0400

This guy is certainly stupid, and deserves punishment. It means I'll
be writting code using emacs for the next week.

Marcelo, please apply


While I appreciate the humour, it means I have to totally rewrite the changelog plus ask a question. Please submit patches with the most boring changelogs you can and reserve the funnies for the "---" section where they belong.

diff --git a/qemu-kvm.c b/qemu-kvm.c
index e200dea..393c5cc 100644
--- a/qemu-kvm.c
+++ b/qemu-kvm.c
@@ -1003,8 +1003,6 @@ int pre_kvm_run(kvm_context_t kvm, CPUState *env)
  {
      kvm_arch_pre_kvm_run(kvm->opaque, env);

-    if (env->exit_request)
-        return 1;
      pthread_mutex_unlock(&qemu_mutex);
      return 0;
  }

Can you explain the failure mode?

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux