Hi, On 11/14/19 2:50 PM, Vladimir Murzin wrote: > On 11/14/19 2:17 PM, Andre Przywara wrote: >> On Thu, 14 Nov 2019 13:39:33 +0000 >> Vladimir Murzin <vladimir.murzin@xxxxxxx> wrote: >> >>> Hi, >>> >>> On 11/12/19 4:42 PM, Alexandru Elisei wrote: >>>> Are we not testing KVM? Why are we not treating a behaviour different than what >>>> KVM should emulate as a fail? >>> Can kvm-unit-tests be run with qemu TCG? >> Yes, it does that actually by default if you cross compile. I also tested this explicitly on TCG: unlike KVM that actually passes all those tests. >> If you set the environment variable ACCEL to either tcg or kvm, you can select this at runtime: >> $ ACCEL=tcg arm/run arm/gic.flat -smp 3 -append irq > Great! Then, IMO, it is absolutely valid to test this functionality! TCG emulates a GIC with a single security state for me: /usr/bin/qemu-system-aarch64 -nodefaults -machine virt,gic-version=3,accel=tcg -cpu cortex-a57 -device virtio-serial-device -device virtconsole,chardev=ctd -chardev testdev,id=ctd -device pci-testdev -display none -serial stdio -kernel arm/gic.flat -append irq PASS: gicv3: irq: SPI triggered by CPU write PASS: gicv3: irq: disabled SPI does not fire PASS: gicv3: irq: now enabled SPI fires INFO: gicv3: irq: GROUP: GIC is one security state only [..] But that could change someday, so I'm fine with failing only if we are not allowed to have GICD_CTLR.DS=1, because that will prevent us from testing group 0 interrupts. Thanks, Alex > Thanks > Vladimir > >> Cheers, >> Andre >>
