On 13/11/19 02:15, Xiaoyao Li wrote:
> When applying commit 7a5ee6edb42e ("KVM: X86: Fix initialization of MSR
> lists"), it forgot to reset the three MSR lists number varialbes to 0
> while removing the useless conditionals.
>
> Fixes: 7a5ee6edb42e (KVM: X86: Fix initialization of MSR lists)
> Signed-off-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx>
> ---
> arch/x86/kvm/x86.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 8c8a5e20ea06..9368b0e6bf21 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -5102,6 +5102,10 @@ static void kvm_init_msr_list(void)
>
> perf_get_x86_pmu_capability(&x86_pmu);
>
> + num_msrs_to_save = 0;
> + num_emulated_msrs = 0;
> + num_msr_based_features = 0;
> +
> for (i = 0; i < ARRAY_SIZE(msrs_to_save_all); i++) {
> if (rdmsr_safe(msrs_to_save_all[i], &dummy[0], &dummy[1]) < 0)
> continue;
>
Ouch. Sorry.
Paolo
