On Mon, Nov 11, 2019 at 04:59:20PM +0200, Liran Alon wrote: > > > > On 11 Nov 2019, at 16:56, Joao Martins <joao.m.martins@xxxxxxxxxx> wrote: > > > > On 11/11/19 2:50 PM, Paolo Bonzini wrote: > >> On 11/11/19 15:48, Joao Martins wrote: > >>>>> > >>>>> Fixes: c112b5f50232 ("KVM: x86: Recompute PID.ON when clearing PID.SN") > >>>>> Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx> > >>>>> Signed-off-by: Liran Alon <liran.alon@xxxxxxxxxx> > >>>> Something wrong in the SoB line? > >>>> > >>> I can't spot any mistake; at least it looks chained correctly for me. What's the > >>> issue you see with the Sob line? > >> > >> Liran's line after yours is confusing. Did he help with the analysis or > >> anything like that? > >> > > He was initially reviewing my patches, but then helped improving the problem > > description in the commit messages so felt correct to give credit. > > > > Joao > > I think proper action is to just remove me from the SoB line. Use Co-developed-by to attribute multiple authors. Note, the SoB ordering should show the chronological history of the patch when possible, e.g. the person sending the patch should always have their SoB last. Documentation/process/submitting-patches.rst and Documentation/process/5.Posting.rst have more details.