Hi tglx, > -----Original Message----- > From: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Sent: Thursday, November 7, 2019 3:56 PM > To: Jianyong Wu (Arm Technology China) <Jianyong.Wu@xxxxxxx> > Cc: netdev@xxxxxxxxxxxxxxx; yangbo.lu@xxxxxxx; john.stultz@xxxxxxxxxx; > pbonzini@xxxxxxxxxx; sean.j.christopherson@xxxxxxxxx; maz@xxxxxxxxxx; > richardcochran@xxxxxxxxx; Mark Rutland <Mark.Rutland@xxxxxxx>; > will@xxxxxxxxxx; Suzuki Poulose <Suzuki.Poulose@xxxxxxx>; linux- > kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > kvmarm@xxxxxxxxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; Steve Capper > <Steve.Capper@xxxxxxx>; Kaly Xin (Arm Technology China) > <Kaly.Xin@xxxxxxx>; Justin He (Arm Technology China) > <Justin.He@xxxxxxx>; nd <nd@xxxxxxx> > Subject: Re: [RFC PATCH v6 4/7] time: Add mechanism to recognize > clocksource in time_get_snapshot > > On Thu, 24 Oct 2019, Jianyong Wu wrote: > > From: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > > > In some scenario like return device time to ptp_kvm guest, we need > > identify the current clocksource outside core time code. > > > > This patch add a mechanism to recognize the current clocksource by > > export clocksource id in time_get_snapshot. > > Please check Documentation/process/submitting-patches.rst and search for > 'This patch'. > Yeah, the expression should be more impersonal. > > diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h > > index b21db536fd52..ac8016b22734 100644 > > --- a/include/linux/clocksource.h > > +++ b/include/linux/clocksource.h > > @@ -19,6 +19,7 @@ > > #include <linux/of.h> > > #include <asm/div64.h> > > #include <asm/io.h> > > +#include <linux/clocksource_ids.h> > > Please place that include to the other linux includes. You might notice that > there is ordering here. > Ok, > But where is that include? It's not part of that series, so how is this supposed > to compile? OMG! Sorry, I added this file when I prepared my patches but missed to include it into this patch! This must be avoid latter. Thanks Jianyong > > Thanks, > > tglx
