The same patch was already sent by Wanpeng Li. See https://lore.kernel.org/lkml/1572848879-21011-1-git-send-email-wanpengli@xxxxxxxxxxx/ On 06.11.19 09:26, Dan Carpenter wrote: > If init_srcu_struct() or init_srcu_struct() fails then this function > returns ERR_PTR(0) which is NULL. It leads to a NULL dereference in the > caller. > > Fixes: 9121923c457d ("kvm: Allocate memslots and buses before calling kvm_arch_init_vm") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > virt/kvm/kvm_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index d16d2054e937..91971811fa5f 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -675,6 +675,7 @@ static struct kvm *kvm_create_vm(unsigned long type) > INIT_HLIST_HEAD(&kvm->irq_ack_notifier_list); > #endif > > + r = -ENOMEM; > if (init_srcu_struct(&kvm->srcu)) > goto out_err_no_srcu; > if (init_srcu_struct(&kvm->irq_srcu)) >
