> From: David Gibson > Sent: Monday, October 28, 2019 1:44 AM > To: Liu, Yi L <yi.l.liu@xxxxxxxxx> > Subject: Re: [RFC v2 06/22] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps > > On Thu, Oct 24, 2019 at 08:34:27AM -0400, Liu Yi L wrote: > > This patch modifies pci_setup_iommu() to set PCIIOMMUOps instead of > > only setting PCIIOMMUFunc. PCIIOMMUFunc is previously used to get an > > address space for a device in vendor specific way. The PCIIOMMUOps > > still offers this functionality. Use PCIIOMMUOps leaves space to add > > more iommu related vendor specific operations. > > > > Cc: Kevin Tian <kevin.tian@xxxxxxxxx> > > Cc: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx> > > Cc: Peter Xu <peterx@xxxxxxxxxx> > > Cc: Eric Auger <eric.auger@xxxxxxxxxx> > > Cc: Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx> > > Cc: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Liu Yi L <yi.l.liu@xxxxxxxxx> > > Reviewed-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> Thanks for the review. Regards, Yi Liu
