On 04/11/19 23:59, Andrea Arcangeli wrote: > kvm_x86_set_hv_timer and kvm_x86_cancel_hv_timer needs to be defined > to succeed the 32bit kernel build, but they can't be called. > > Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx> > --- > arch/x86/kvm/vmx/vmx.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index bd17ad61f7e3..1a58ae38c8f2 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -7195,6 +7195,17 @@ void kvm_x86_cancel_hv_timer(struct kvm_vcpu *vcpu) > { > to_vmx(vcpu)->hv_deadline_tsc = -1; > } > +#else > +int kvm_x86_set_hv_timer(struct kvm_vcpu *vcpu, u64 guest_deadline_tsc, > + bool *expired) > +{ > + BUG(); > +} > + > +void kvm_x86_cancel_hv_timer(struct kvm_vcpu *vcpu) > +{ > + BUG(); > +} > #endif > > void kvm_x86_sched_in(struct kvm_vcpu *vcpu, int cpu) > I'll check for how long this has been broken. It may be the proof that we can actually drop 32-bit KVM support. Paolo