On Sat, Oct 26, 2019 at 11:23:58AM +0800, Zhenzhong Duan wrote: > dev->poll_limit_ns could be zeroed in certain cases (e.g. by > guest_halt_poll_shrink). If guest_halt_poll_grow_start is zero, > dev->poll_limit_ns will never be larger than zero. > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx> > --- > drivers/cpuidle/governors/haltpoll.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) I would rather disallow setting grow_start to zero rather than silently setting it to one on the back of the user.